Refactor: Move Evaluator before Advancer in Daemon loop#752
Merged
Conversation
…execute→cron
All spec documents now consistently follow the DESIGN.md canonical loop order.
Changes:
- daemon.md: add evaluator.evaluate() to summary loop pseudocode
- lifecycle-hook.md: insert evaluate step, renumber steps 2→5, remove
stale force_trigger("evaluate") call
- queue-state-machine.md: replace "evaluate cron" with "Evaluator (Daemon tick)"
- DESIGN.md: fix Actor table to "수집→분류→전이→실행→반영" order
- Replace all v6 "evaluate cron" references with "Evaluator (Daemon tick)"
https://claude.ai/code/session_01Qfqe81zxg7nS4yhNeALiVP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructure the Daemon's main loop to execute the Evaluator (classification/judgment phase) before the Advancer (state transition phase), establishing a clearer Progressive Pipeline architecture. This change also updates terminology throughout the codebase from "evaluate cron" to "Evaluator" to reflect the new architectural role.
Key Changes
Daemon loop reordering: Moved
evaluator.evaluate()to execute immediately after collection and before state advancementforce_trigger)Removed force_trigger mechanism: Eliminated
force_trigger("evaluate")call from Executor, as Evaluator now runs proactively in each Daemon tickTerminology updates: Replaced "evaluate cron" with "Evaluator (Daemon tick)" throughout documentation to clarify that evaluation is now a first-class phase in the main loop, not a separate cron job
Updated architectural descriptions:
Implementation Details
The change establishes a clearer separation of concerns:
This Progressive Pipeline ensures classification decisions are made before items advance to Running state, improving decision quality and reducing race conditions.
https://claude.ai/code/session_01Qfqe81zxg7nS4yhNeALiVP